Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing that feels unnecessarily awkward today is to be able to just retrieve any keyboard input as a key event, from within a Revery app. This is important for games.
The
<Calculator />example actually has a component that handles this in a brute force way - it grabs focus on mount, and then listens for blur events, and steals the focus back. This helps in the case where a mouse click would 'blur'. This change brings this component to our API.I believe there may also be a bug with our mouse-blur handling, where it blurs too aggressively - that might be worth looking at as a separate issue.
Open Issues:
<KeyboardInput />components? They'll ping-pong focus back and forth.